Add contributor guide #5426

ncapps · 2023-10-30T21:43:40Z

Add a contributor guide.

Resolves #5199

k8s-ci-robot · 2023-10-30T21:43:43Z

This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2023-10-30T21:43:50Z

Hi @ncapps. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

annasong20 · 2023-10-30T21:46:14Z

/ok-to-test

ncapps · 2023-10-30T22:00:51Z

/label tide/merge-method-squas

k8s-ci-robot · 2023-10-30T22:00:53Z

@ncapps: The label(s) /label tide/merge-method-squas cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label tide/merge-method-squas

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ncapps · 2023-10-30T22:03:36Z

/label tide/merge-method-squash

antoooks · 2023-10-31T04:11:28Z

Looks good to me

/lgtm

k8s-ci-robot · 2023-10-31T04:11:32Z

@antoooks: changing LGTM is restricted to collaborators

In response to this:

Looks good to me

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bugoverdose

Just some minor comments.

CONTRIBUTING.md

bugoverdose · 2023-10-31T04:24:00Z

CONTRIBUTING.md

+You will need to periodically fetch changes from the `upstream` repository to keep your working branch in sync.
+```bash


Below is an example of creating a new branch to work on.

Maybe we can add example of syncing working branches that were already created on upstream repository changes.

+1. I think it'd be a good idea to split the part that speaks to syncing a fork from the part that creates a new working branch.

charles-chenzz

from the contributor side, this lgtm
/lgtm

stormqueen1990

Hi @ncapps, thanks for working on this! 😄

I left a few suggestions in comments and a small correction for a link that's not currently working.

stormqueen1990 · 2023-11-01T02:28:08Z

CONTRIBUTING.md

+You will need to periodically fetch changes from the `upstream` repository to keep your working branch in sync.
+```bash


+1. I think it'd be a good idea to split the part that speaks to syncing a fork from the part that creates a new working branch.

CONTRIBUTING.md

charles-chenzz

only one minor question

CONTRIBUTING.md

natasha41575

/lgtm
/approve

/hold in case there are other changes you want to make before this merges

Feel free to remove the hold with /hold cancel when you are ready to merge (or ping me if the bot doesn't respond to your command

natasha41575 · 2023-11-03T19:24:34Z

CONTRIBUTING.md

+cd kustomize
+
+# Configure upstream
+git remote add upstream https://github.com/kubernetes-sigs/kustomize


Genuine question (you don't have to change anything if this is how you have yours set up, since it seems to be working great) - Does it make a difference if we use the ssh URL for the upstream vs the http one? I have my upstream configured with the ssh one, but I'm not sure if that actually affects anything in our workflows

The only difference I think I've observed is that

ssh: you need to authenticate for push and pull, but you can use 2 factor

http: you only need to authenticate for push, but you need to enter your password
Given that we don't need to push to upstream, I think http is probably easier

k8s-ci-robot · 2023-11-03T19:27:00Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: natasha41575, ncapps

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [natasha41575]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ncapps · 2023-11-03T21:19:41Z

/hold cancel

* Add contributor guide * git merge upstream/master * git rebase upstream/master * make test-unit-all * make lint

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 30, 2023

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 30, 2023

k8s-ci-robot requested review from koba1t and natasha41575 October 30, 2023 21:43

ncapps marked this pull request as ready for review October 30, 2023 21:44

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 30, 2023

k8s-ci-robot requested review from annasong20 and yuwenma October 30, 2023 21:44

ncapps changed the title ~~Add contribute guide~~ Add contributor guide Oct 30, 2023

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 30, 2023

k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Oct 30, 2023

bugoverdose reviewed Oct 31, 2023

View reviewed changes

charles-chenzz reviewed Oct 31, 2023

View reviewed changes

k8s-ci-robot assigned charles-chenzz Oct 31, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2023

stormqueen1990 reviewed Nov 1, 2023

View reviewed changes

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 1, 2023

ncapps force-pushed the docs/contributor-guide branch from 0a423e2 to be35c55 Compare November 1, 2023 18:05

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 1, 2023

charles-chenzz reviewed Nov 1, 2023

View reviewed changes

CONTRIBUTING.md Show resolved Hide resolved

charles-chenzz reviewed Nov 1, 2023

View reviewed changes

chlunde reviewed Nov 2, 2023

View reviewed changes

CONTRIBUTING.md Outdated Show resolved Hide resolved

ncapps added 5 commits November 2, 2023 22:47

Add contributor guide

b50f671

git merge upstream/master

60ea143

git rebase upstream/master

6102a6e

make test-unit-all

62ef01a

make lint

08fa96f

ncapps force-pushed the docs/contributor-guide branch from 8947d18 to 08fa96f Compare November 3, 2023 03:59

natasha41575 reviewed Nov 3, 2023

View reviewed changes

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 3, 2023

k8s-ci-robot assigned natasha41575 Nov 3, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 3, 2023

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2023

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 3, 2023

k8s-ci-robot merged commit e7c8ed1 into kubernetes-sigs:master Nov 3, 2023
5 checks passed

ncapps mentioned this pull request Nov 13, 2023

REQUEST: New membership for @ncapps kubernetes/org#4583

Closed

9 tasks

antoooks pushed a commit to antoooks/kustomize that referenced this pull request Nov 21, 2023

Add contributor guide (kubernetes-sigs#5426)

7aba71b

* Add contributor guide * git merge upstream/master * git rebase upstream/master * make test-unit-all * make lint

ncapps mentioned this pull request Dec 1, 2023

Add ncapps to reviewers #5469

Merged

ncapps deleted the docs/contributor-guide branch December 2, 2023 03:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add contributor guide #5426

Add contributor guide #5426

ncapps commented Oct 30, 2023

k8s-ci-robot commented Oct 30, 2023

k8s-ci-robot commented Oct 30, 2023

annasong20 commented Oct 30, 2023

ncapps commented Oct 30, 2023

k8s-ci-robot commented Oct 30, 2023

ncapps commented Oct 30, 2023

antoooks commented Oct 31, 2023

k8s-ci-robot commented Oct 31, 2023

bugoverdose left a comment

bugoverdose Oct 31, 2023

stormqueen1990 Nov 1, 2023

charles-chenzz left a comment

stormqueen1990 left a comment

stormqueen1990 Nov 1, 2023

charles-chenzz left a comment

natasha41575 left a comment

natasha41575 Nov 3, 2023 •

edited

Loading

annasong20 Nov 3, 2023

k8s-ci-robot commented Nov 3, 2023

ncapps commented Nov 3, 2023

		You will need to periodically fetch changes from the `upstream` repository to keep your working branch in sync.
		```bash

Add contributor guide #5426

Add contributor guide #5426

Conversation

ncapps commented Oct 30, 2023

k8s-ci-robot commented Oct 30, 2023

k8s-ci-robot commented Oct 30, 2023

annasong20 commented Oct 30, 2023

ncapps commented Oct 30, 2023

k8s-ci-robot commented Oct 30, 2023

ncapps commented Oct 30, 2023

antoooks commented Oct 31, 2023

k8s-ci-robot commented Oct 31, 2023

bugoverdose left a comment

Choose a reason for hiding this comment

bugoverdose Oct 31, 2023

Choose a reason for hiding this comment

stormqueen1990 Nov 1, 2023

Choose a reason for hiding this comment

charles-chenzz left a comment

Choose a reason for hiding this comment

stormqueen1990 left a comment

Choose a reason for hiding this comment

stormqueen1990 Nov 1, 2023

Choose a reason for hiding this comment

charles-chenzz left a comment

Choose a reason for hiding this comment

natasha41575 left a comment

Choose a reason for hiding this comment

natasha41575 Nov 3, 2023 • edited Loading

Choose a reason for hiding this comment

annasong20 Nov 3, 2023

Choose a reason for hiding this comment

k8s-ci-robot commented Nov 3, 2023

ncapps commented Nov 3, 2023

natasha41575 Nov 3, 2023 •

edited

Loading